ptrendx commented on issue #16553: Fix for wrong reqs set after switching from training to inference URL: https://github.com/apache/incubator-mxnet/pull/16553#issuecomment-544336113 For 1: this error was found when working on pointwise fusion, which uses reqs to compile the right code. I don't know if there is any other operator which may not write to an output if there is no backward pass for it (I know `mx.sym.contrib.box_nms` would have that behavior, but the current implementation writes to the output only used for backward every time, without looking at the req value). I can add the test in pointwise fusion PR, show that it fails and then merge with master once this fix is in to show that it does not fail anymore. For 2: I agree, probably as `const static` members of `CachedOp`?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
