TaoLv commented on issue #16555: Upgrade MKL-DNN dependency to v1.0
URL: https://github.com/apache/incubator-mxnet/pull/16555#issuecomment-545999057
 
 
   @matteosal Thank you for reporting. Have you ever tried this case with the 
latest master branch?
   
   To help us to isolate the issue, could you please comment out below lines 
from src/operator/tensor/matrix_op.cc and then build mxnet and test your case 
again?
   ```
   diff --git a/src/operator/tensor/matrix_op.cc 
b/src/operator/tensor/matrix_op.cc
   index 0f63061..10b15d4 100644
   --- a/src/operator/tensor/matrix_op.cc
   +++ b/src/operator/tensor/matrix_op.cc
   @@ -180,14 +180,14 @@ If the argument `reverse` is set to 1, then the 
special values are inferred from
    .set_attr<nnvm::FInferType>("FInferType", ElemwiseType<1, 1>)
    .set_attr<nnvm::FGradient>("FGradient", 
ElemwiseGradUseNone{"_backward_reshape"})
    .set_attr<FCompute>("FCompute<cpu>", UnaryOp::IdentityCompute<cpu>)
   -#if MXNET_USE_MKLDNN == 1
   -.set_attr<bool>("TIsMKLDNN", true)
   -.set_attr<FComputeEx>("FComputeEx<cpu>", ReshapeComputeExCPU)
   -.set_attr<FInferStorageType>("FInferStorageType", ReshapeStorageType)
   -.set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& n) {
   -  return std::vector<ResourceRequest>{ResourceRequest::kTempSpace};
   -})
   -#endif
   +// #if MXNET_USE_MKLDNN == 1
   +// .set_attr<bool>("TIsMKLDNN", true)
   +// .set_attr<FComputeEx>("FComputeEx<cpu>", ReshapeComputeExCPU)
   +// .set_attr<FInferStorageType>("FInferStorageType", ReshapeStorageType)
   +// .set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& n) {
   +//   return std::vector<ResourceRequest>{ResourceRequest::kTempSpace};
   +// })
   +// #endif
    .set_attr<nnvm::FInplaceOption>("FInplaceOption",
      [](const NodeAttrs& attrs) {
        return std::vector<std::pair<int, int> >{{0, 0}};
   @@ -403,14 +403,14 @@ will return a new array with shape ``(2,1,3,4)``.
      })
    .set_attr<nnvm::FGradient>("FGradient", 
ElemwiseGradUseNone{"_backward_reshape"})
    .set_attr<FCompute>("FCompute<cpu>", UnaryOp::IdentityCompute<cpu>)
   -#if MXNET_USE_MKLDNN == 1
   -.set_attr<bool>("TIsMKLDNN", true)
   -.set_attr<FComputeEx>("FComputeEx<cpu>", ExpandDimEx)
   -.set_attr<FInferStorageType>("FInferStorageType", ExpandDimStorageType)
   -.set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& n) {
   -  return std::vector<ResourceRequest>{ResourceRequest::kTempSpace};
   -})
   -#endif
   +// #if MXNET_USE_MKLDNN == 1
   +// .set_attr<bool>("TIsMKLDNN", true)
   +// .set_attr<FComputeEx>("FComputeEx<cpu>", ExpandDimEx)
   +// .set_attr<FInferStorageType>("FInferStorageType", ExpandDimStorageType)
   +// .set_attr<FResourceRequest>("FResourceRequest", [](const NodeAttrs& n) {
   +//   return std::vector<ResourceRequest>{ResourceRequest::kTempSpace};
   +// })
   +// #endif
    .add_argument("data", "NDArray-or-Symbol", "Source input")
    .add_arguments(ExpandDimParam::__FIELDS__());
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to