apeforest commented on a change in pull request #16184: Add large tensor nightly tests for MKL-DNN operators URL: https://github.com/apache/incubator-mxnet/pull/16184#discussion_r342922471
########## File path: tests/nightly/test_large_array.py ########## @@ -619,9 +631,16 @@ def testSoftmaxOutput(): sym = mx.sym.SoftmaxOutput(data=x, label=label, ignore_label=0, use_ignore=False) + ex = sym.bind(ctx=default_context(), args={'x': x_nd, 'label': label_nd}, - args_grad={'x': grad_x}) + args_grad=None) + ex.forward(is_train=False) + softmax_out = ex.outputs[0][0].asnumpy() + expected_softmax_out = (1/SMALL_Y)*mx.nd.ones((SMALL_Y)).asnumpy() Review comment: nit: add space between operators and operands ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services