DickJC123 opened a new pull request #16783: Speed fused_op compilation by caching ptx and jit-compiled device functions URL: https://github.com/apache/incubator-mxnet/pull/16783 ## Description ## This PR speeds up the dynamic nvrtc-compilation of fused_ops in response to @rondogency's comment https://github.com/apache/incubator-mxnet/pull/15167#issuecomment-550008831. As reported in the comment, the runtime of 3 mentioned unittests had grown drastically with the fusion enabled to 17.5 minutes in total. With this PR, the runtime drops to 1 minute, with the original fusion-turned-off runtime being 30 seconds. The process of runtime compilation of NVIDIA gpu kernels involves 2 steps: - compiling the cuda code to PTX assembly (performed once per GPU architecture) - translating the ptx assembly to binary and loading it into a GPU's set of runnable kernels (performed once per GPU device). This latter step produces the CUfunction needed to execute the kernel on the device. Realizing the the slowed-down unittests involved creating many identical fused ops, a cache of the PTX and CUfunctions was created. The cache comprises a mapping (for each GPU arch) from the cuda source code to the PTX and to any CUfunctions created from it. It's worth a reminder that the fusion framework is targeting the typical scenario of creating a model's graph and executing it many times. The CI was adversely impacted because it often executes a model's graph just once after creation. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [ X] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes) - [X ] Changes are complete (i.e. I finished coding on this PR) - [X ] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore) - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL) - [X ] Code is well-documented: - For user-facing API changes, API doc string has been updated. - For new C++ functions in header files, their functionalities and arguments are documented. - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable - Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html - [X ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - [ ] Feature1, tests, (and when applicable, API doc) - [ ] Feature2, tests, (and when applicable, API doc) ## Comments ## - If this change is a backward incompatible change, why must this change be made. - Interesting edge cases to note here
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
