liuzh91 commented on a change in pull request #16888: Add evaluation_loss to
the estimator base class.
URL: https://github.com/apache/incubator-mxnet/pull/16888#discussion_r349978294
##########
File path: python/mxnet/gluon/contrib/estimator/estimator.py
##########
@@ -64,13 +64,17 @@ def __init__(self, net,
metrics=None,
initializer=None,
trainer=None,
- context=None):
+ context=None,
+ evaluation_loss=None):
self.net = net
self.loss = self._check_loss(loss)
self._train_metrics = _check_metrics(metrics)
self._add_default_training_metrics()
self._add_validation_metrics()
+ self.evaluation_loss = None
Review comment:
If users need customized evaluation loss in the base estimator, they cannot
do that any more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
