reminisce commented on a change in pull request #16895: Fix ndarray indexing bug
URL: https://github.com/apache/incubator-mxnet/pull/16895#discussion_r350371535
##########
File path: src/ndarray/ndarray.cc
##########
@@ -243,8 +243,14 @@ NDArray NDArray::MKLDNNDataReshape(const mxnet::TShape
&shape) const {
NDArray NDArray::Reshape(const mxnet::TShape &shape) const {
CHECK(!is_none()) << "NDArray is not initialized";
- CHECK_GE(shape_.Size(), shape.Size())
- << "NDArray.Reshape: target shape size is larger current shape";
+ if (Imperative::Get()->is_np_shape()) {
+ CHECK_EQ(shape_.Size(), shape.Size())
+ << "NDArray.Reshape: target shape must have the same size as "
+ << "current shape.";
+ } else {
+ CHECK_GE(shape_.Size(), shape.Size())
+ << "NDArray.Reshape: target shape size is larger current shape";
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
