apeforest commented on a change in pull request #16903: changing data type of
't' to int in lamb_update_phase1
URL: https://github.com/apache/incubator-mxnet/pull/16903#discussion_r350480484
##########
File path: src/operator/optimizer_op-inl.h
##########
@@ -1639,8 +1639,8 @@ struct LambUpdatePhaseOneKernel {
DType g = mean_data[i] / (square_root::Map(var_data[i]) + epsilon) + wd *
weight_data[i];
if (bias_correction) {
- DType mean_hat = mean_data[i] / (1. - power::Map(beta1, t));
- DType var_hat = var_data[i] / (1 - power::Map(beta2, t));
+ DType mean_hat = mean_data[i] / (1. - std::pow(beta1, t));
Review comment:
Can we still re-use the power::Map() data structure here with a new
signature for Map()?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
