wkcn edited a comment on issue #16909: Build with cv 4.0 URL: https://github.com/apache/incubator-mxnet/pull/16909#issuecomment-558473934 Thank you for the contribution! We don't need to replace the two macros. We need the compatibility with the lower version of OpenCV. The lower version doesn't define `cv::IMWRITE_PNG_COMPRESSION` and `cv::IMWRITE_JPEG_QUALITY`. If using OpenCV4, the file [`src/io/opencv_compatibility.h`](https://github.com/apache/incubator-mxnet/blob/master/src/io/opencv_compatibility.h) will define the two macros: `CV_IMWRITE_PNG_COMPRESSION` and `CV_IMWRITE_JPEG_QUALITY`. https://github.com/apache/incubator-mxnet/blob/f11592da86f24ddbc7ea63d0e7d6a5c84153f606/src/io/opencv_compatibility.h#L52-L53 Thanks again : )
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
