ewail commented on issue #16909: Build with cv 4.0 URL: https://github.com/apache/incubator-mxnet/pull/16909#issuecomment-558605965 > Thank you for the contribution! > > We need the compatibility with the lower version of OpenCV. The lower version doesn't define `cv::IMWRITE_PNG_COMPRESSION` and `cv::IMWRITE_JPEG_QUALITY`. > > I recommend to re-define the macro when using OpenCV4, like [src/io/opencv_compatibility.h](https://github.com/apache/incubator-mxnet/blob/master/src/io/opencv_compatibility.h#L52-L53). > > ```c++ > #if CV_VERSION_MAJOR >= 4 > #include <opencv2/opencv.hpp> > #define CV_IMWRITE_PNG_COMPRESSION cv::IMWRITE_PNG_COMPRESSION > #define CV_IMWRITE_JPEG_QUALITY cv::IMWRITE_JPEG_QUALITY > #endif // CV_VERSION_MAJOR >= 4 > ``` > > Thanks again : ) Many Thanks, and let me test that.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
