eric-haibin-lin commented on a change in pull request #16922: Update
LoggingHandler to support logging per interval
URL: https://github.com/apache/incubator-mxnet/pull/16922#discussion_r352232671
##########
File path: python/mxnet/gluon/contrib/estimator/event_handler.py
##########
@@ -286,21 +293,31 @@ def train_end(self, estimator, *args, **kwargs):
estimator.logger.info(msg.rstrip(', '))
def batch_begin(self, estimator, *args, **kwargs):
- if self.verbose == self.LOG_PER_BATCH:
+ if self.verbose >= self.LOG_PER_BATCH:
Review comment:
this assumes the order of these constant variables. Better to use `if
self.verbose in [var1, var2]` instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
