TaoLv commented on a change in pull request #16979: [Bugfix] [Numpy] Add
`kAddTo` and kNullOp to Transpose
URL: https://github.com/apache/incubator-mxnet/pull/16979#discussion_r354140381
##########
File path: src/operator/tensor/matrix_op.cc
##########
@@ -283,11 +283,12 @@ static void TransposeComputeExCPU(const nnvm::NodeAttrs&
attrs,
return;
}
const TransposeParam& param = nnvm::get<TransposeParam>(attrs.parsed);
- CHECK_EQ(req[0], kWriteTo) << "Transpose does not support kWriteInplace and
kAddTo";
+ CHECK(req[0] == kWriteTo || req[0] == kAddTo) <<
+ "Transpose only supports kNullOp, kWriteTo and kAddTo";
CHECK_EQ(inputs.size(), 1U);
CHECK_EQ(outputs.size(), 1U);
- if (SupportMKLDNNTranspose(param, inputs[0])) {
+ if (SupportMKLDNNTranspose(param, inputs[0]) && req[0] == kWriteTo) {
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
