liuzh91 opened a new pull request #17051: fix parameter names in the estimator api URL: https://github.com/apache/incubator-mxnet/pull/17051 ## Description ## This fix is to make parameter names of estimator api consistent. Previously, we have `val_metrics`, `eval_net` and `evaluation_loss` refer to the metrics, model and loss used during validation. To make the names consistent, we change these names to `val_metrics`, `val_net` and `val_loss`. So every parameter shares a common prefix of `val_` for validation. ## Checklist ## ### Essentials ### - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage: - Unit tests are added for small changes to verify correctness (e.g. adding a new operator) - [x] Code is well-documented: - For user-facing API changes, API doc string has been updated. - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
