apeforest commented on a change in pull request #17010: [API] unified API for
custom kvstores
URL: https://github.com/apache/incubator-mxnet/pull/17010#discussion_r357856194
##########
File path: python/mxnet/model.py
##########
@@ -171,9 +182,11 @@ def _update_params(param_arrays, grad_arrays, updater,
num_device,
if kvstore:
name = param_names[index]
# push gradient, priority is negative index
- kvstore.push(name, grad_list, priority=-index)
- # pull back the sum gradients, to the same locations.
- kvstore.pull(name, grad_list, priority=-index)
+ if grad_list[0].stype == 'default' and arg_list[0].stype ==
'default':
Review comment:
Where is 'default' defined?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
