eric-haibin-lin commented on a change in pull request #17010: [API] unified API
for custom kvstores
URL: https://github.com/apache/incubator-mxnet/pull/17010#discussion_r357867034
##########
File path: python/mxnet/kvstore/kvstore.py
##########
@@ -327,39 +344,37 @@ def pushpull(self, key, value, out=None, priority=0):
key : str, int, or sequence of str or int
Keys.
- value : NDArray, RowSparseNDArray, list of NDArray or RowSparseNDArray,
- or list of list of NDArray or RowSparseNDArray
+ value : NDArray, list of NDArray, or list of list of NDArray
Values corresponding to the keys.
out: NDArray or list of NDArray or list of list of NDArray
Values corresponding to the keys.
priority : int, optional
- The priority of the pull operation.
- Higher priority pull operations are likely to be executed before
- other pull actions.
+ The priority of the operation.
Review comment:
the type is int. int can be positive or negative. So 0 is neither highest or
lowest.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services