leezu commented on a change in pull request #17063: Fix armv7 build by updating the base container and pin it URL: https://github.com/apache/incubator-mxnet/pull/17063#discussion_r357887105
########## File path: ci/docker/Dockerfile.build.armv7 ########## @@ -18,7 +18,10 @@ # # Dockerfile to build MXNet for Android ARMv7 -FROM mxnetcipinned/dockcross-linux-armv7:11262018 +# The container is pinned for preventing CI failures on updates, swap below to use +# the upstream container +#FROM dockcross/linux-armv7 +FROM mxnetci/dockcross-linux-armv7-pinned Review comment: If you only specify the name `mxnetci/dockcross-linux-armv7-pinned`, instead of `mxnetci/dockcross-linux-armv7-pinned:TAG`, docker will always pull the version tagged as `latest`: `mxnetci/dockcross-linux-armv7-pinned:latest`. But that version changes whenever someone pushes a new version of `dockcross-linux-armv7-pinned` to `mxnetci`. So it becomes impossible to test if an update of `dockcross-linux-armv7-pinned` breaks the CI. Instead all CI runs will be changed immediately. If instead you add a tag `TAG` for the particular version of the `mxnetci/dockcross-linux-armv7-pinned` container at https://hub.docker.com/r/mxnetci/dockcross-linux-armv7-pinned/tags, our Dockerfiles here on Github can mention the tag `mxnetci/dockcross-linux-armv7-pinned:TAG`. Then, when pushing a new update of `dockcross-linux-armv7-pinned` to `mxnetci` and tagged as `TAG2`, the CI will continue to use the old version until a PR is opened to update to use `TAG2` on github. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
