leezu commented on issue #17051: fix parameter names in the estimator api URL: https://github.com/apache/incubator-mxnet/pull/17051#issuecomment-565881693 @sxjscience the problem is that the API was changed on November 1, even though the code-freeze was in effect since 2019-10-25. The change of November 1 was later discovered to be incomplete and @liuzh91 worked hard to fix it. I agree with you that in retrospect it would be better to revert the change from November 1 and include all changes to the `master` only, instead of trying to fix `1.6` during the code freeze. While the code is experimental, we shouldn't break it unnecessarily between releases. Thus I suggest we either remove the incomplete Estimator API changes from `1.6`, or we decide the current naming is fine, or we fix the naming in `1.6` release. Changing only the naming in the 1.7 release seems bad to me.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
