larroy commented on a change in pull request #17063: Fix armv7 build by updating the base container and pin it URL: https://github.com/apache/incubator-mxnet/pull/17063#discussion_r358387653
########## File path: ci/docker/Dockerfile.build.armv7 ########## @@ -18,7 +18,10 @@ # # Dockerfile to build MXNet for Android ARMv7 -FROM mxnetcipinned/dockcross-linux-armv7:11262018 +# The container is pinned for preventing CI failures on updates, swap below to use +# the upstream container +#FROM dockcross/linux-armv7 +FROM mxnetci/dockcross-linux-armv7-pinned Review comment: The pinned image needs to be maintained automatically. It's a good point with the credentials. We might consider having it in a private pipeline with a different repo to preserve those credentials. Edit: now that I think of it from a security perspective doesn't matter much since we are generating the mxnetci images from an unsafe environment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
