TaoLv commented on a change in pull request #16735: Use single-bit for mask in
dropout operator
URL: https://github.com/apache/incubator-mxnet/pull/16735#discussion_r360930552
##########
File path: src/operator/nn/dropout-inl.h
##########
@@ -396,10 +475,9 @@ class DropoutOp {
mshadow::Shape<NDim> rstride =
mxnet_op::calc_stride(new_rshape.get<NDim>());
mxnet_op::Kernel<mxnet_op::binary_broadcast_kernel<NDim,
mshadow_op::mul>, xpu>::
template LaunchEx(s, new_oshape.Size(), req[dropout::kOut],
- lstride, rstride, oshape,
- in.dptr<DType>(),
- mask.dptr<DType>(), out.dptr<DType>());
- });
+ lstride, rstride, oshape, in.dptr<DType>(),
+ temp.dptr_, out.dptr<DType>());
+ })
Review comment:
Better to add a semicolon here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
