larroy commented on a change in pull request #16125: julia: migrate build
process to cmake
URL: https://github.com/apache/incubator-mxnet/pull/16125#discussion_r361043643
##########
File path: cmake/Modules/FindOpenBLAS.cmake
##########
@@ -89,3 +90,21 @@ MARK_AS_ADVANCED(
OpenBLAS
)
+# Check ILP64 data model for the case of Julia self-shipped
`libopenblas64_.so`
Review comment:
I don't know much, but maybe you can simplify a bit using
CHECK_SOURCE_COMPILES and similar.
https://gitlab.kitware.com/cmake/community/wikis/doc/tutorials/How-To-Write-Platform-Checks
Overall looks ok-ish to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
