iblis17 commented on a change in pull request #16125: julia: migrate build
process to cmake
URL: https://github.com/apache/incubator-mxnet/pull/16125#discussion_r361180062
##########
File path: julia/deps/build.jl
##########
@@ -137,7 +138,7 @@ if !libmxnet_detected
run(download_cmd(package_url, "mxnet.7z"))
# this command will create the dir "usr\\lib"
- run(`$exe7z e mxnet.7z *\\build\\* *\\lib\\* -y -ousr\\lib`)
+ run(`$exe7z e mxnet.7z "*\\build\\*" "*\\lib\\*" -y -ousr\\lib`) # TODO
check it works on windows or not
Review comment:
ah, I checked it on Window, but forgot to remove the comment.
The previous code just poped some warning about quoting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
