samskalicky commented on a change in pull request #17034: [WIP] Dynamic
subgraph property
URL: https://github.com/apache/incubator-mxnet/pull/17034#discussion_r361998081
##########
File path: CMakeLists.txt
##########
@@ -718,7 +718,9 @@ else()
endif()
add_library(sample_lib SHARED
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_custom_op/gemm_lib.cc)
+add_library(subgraph_lib SHARED
${CMAKE_CURRENT_SOURCE_DIR}/example/extensions/lib_subgraph/subgraph_lib.cc)
Review comment:
No, I would like them to diverge and stay separate. Subgraph lib should just
be the minimal required to support an accelerator in MXNet: subgraph property &
subgraph operator. If the user also wants to add a regular custom operator
thats up to them. Subgraph libs will only use a stateful operator, where as
custom ops may be implemented with stateless operators too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
