samskalicky commented on a change in pull request #17204: Enhancements for
MXTensor for custom operators
URL: https://github.com/apache/incubator-mxnet/pull/17204#discussion_r363019493
##########
File path: include/mxnet/lib_api.h
##########
@@ -277,6 +283,14 @@ struct MXTensor {
return size;
}
+ /*! \brief helper function to compare two MXTensors */
+ inline bool isSame(const MXTensor &oth) {
Review comment:
I think I agree with @wkcn here, == should compare the values of the tensor
not the "state" of the tensor (data_ptr, versionID, etc)
@mseth10 @eric-haibin-lin @haojin2 what do you guys think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
