DickJC123 commented on issue #17049: Fix operators lying about their number of inputs URL: https://github.com/apache/incubator-mxnet/pull/17049#issuecomment-571877924 Thanks for carrying through on this issue. I remember running into the problem and getting only as far as describing the issue with this incomplete PR https://github.com/apache/incubator-mxnet/pull/15834. I reviewed my implementation of the input check there and I like that you have pushed the check down into MakeNode(). However, I notice in my implementation, I was protecting the routine MakeNonLossGradNode, where you don't have a similar check because MakeNode() is called with inputs=null. Could you review my commit above and add a check for MakeNonLossGradNode if you feel it enhances the protection?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
