anirudh2290 commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r365089562
##########
File path: src/imperative/cached_op.h
##########
@@ -26,8 +26,180 @@
#include <utility>
#include <string>
#include <unordered_map>
+#include <map>
+#include "../operator/operator_common.h"
+#include "../operator/subgraph/common.h"
+#include "./imperative_utils.h"
namespace mxnet {
+namespace {
+
+ static const char FULL[] = "full";
+ static const char FORWARD[] = "forward";
+ static const char BACKWARD[] = "backward";
+ static const char REF_COUNT[] = "ref_count";
+ static const char MEM_PLAN[] = "mem_plan";
+ static const char STORAGE_PLAN[] = "storage_plan";
+
+std::string AddPrefix(const std::string& prefix,
+ const std::string& s) {
+ return prefix + "_" + s;
+}
+void CreateFullGraph(const nnvm::Symbol& sym,
+ nnvm::Graph* fwd_graph,
+ nnvm::Graph* grad_graph,
+ nnvm::Graph* full_graph,
+ std::vector<nnvm::NodeEntry>* ograd_entries,
+ std::unordered_map<uint32_t, uint32_t>*
fwd_input_to_grad_output) {
+ using namespace nnvm;
+ static const std::vector<const Op*> zero_ops{Op::Get("zeros_like"),
Op::Get("_zeros")};
+ static const auto _copy_op = Op::Get("_copy");
+ {
+ NodeEntryMap<size_t> dedup_out;
+ for (const NodeEntry& nodeEntry : sym.outputs) {
+ if (dedup_out.find(nodeEntry) != dedup_out.end()) {
+ NodePtr copy_node = Node::Create();
+ copy_node->attrs.op = _copy_op;
+ copy_node->attrs.name =
+ nodeEntry.node->attrs.name + "_copy" +
std::to_string(dedup_out[nodeEntry]++);
+ copy_node->inputs.emplace_back(nodeEntry);
+ if (_copy_op->attr_parser != nullptr) {
+ _copy_op->attr_parser(&(copy_node->attrs));
+ }
+ fwd_graph->outputs.emplace_back(std::move(copy_node));
+ } else {
+ dedup_out.emplace(nodeEntry, 0);
+ fwd_graph->outputs.push_back(nodeEntry);
+ }
+ }
+ }
+
+ bool do_elim_common_expr = dmlc::GetEnv("MXNET_ELIMINATE_COMMON_EXPR", true);
Review comment:
this function was from before, its outside the scope of this pr. Feel free
to add a new PR for refactoring this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
