leezu commented on issue #17239: Cmake with NCCL flag does not work. URL: https://github.com/apache/incubator-mxnet/issues/17239#issuecomment-573622552 @apeforest could you provide some background if NCCL is installed at `/usr/local/cuda/include` by default? @ChaiBapchya your change seems to rely on `CUDA_TOOLKIT_ROOT_DIR`, but this variable is not among the variables exported by `FindCUDAToolkit`. In fact, you can see it's explicitly unset: https://github.com/apache/incubator-mxnet/blob/master/cmake/Modules/FindCUDAToolkit.cmake#L708 Instead, let's use the result variables https://github.com/apache/incubator-mxnet/blob/28e053edb4f2079743458bf087557bcac7e58c62/cmake/Modules/FindCUDAToolkit.cmake#L427-L464 Specifically `CUDAToolkit_INCLUDE_DIRS` and `CUDAToolkit_LIBRARY_DIR`? Or would the nccl library not be at the `CUDAToolkit_LIBRARY_DIR`? Besides using the `CUDAToolkit` variables as additional defaults to find nccl, the `NCCL_ROOT` variable needs to be examined as per https://cmake.org/cmake/help/latest/policy/CMP0074.html (which is done correctly currently I think)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
