anirudh2290 commented on a change in pull request #16654: Multithreaded
Inference Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r366074730
##########
File path: src/imperative/cached_op.cc
##########
@@ -32,247 +32,12 @@ DMLC_REGISTER_PARAMETER(CachedOpConfig);
constexpr uint32_t kEidNotExist = std::numeric_limits<uint32_t>::max();
-const char CachedOp::FULL[] = "full";
-const char CachedOp::FORWARD[] = "forward";
-const char CachedOp::BACKWARD[] = "backward";
-const char CachedOp::REF_COUNT[] = "ref_count";
-const char CachedOp::MEM_PLAN[] = "mem_plan";
-const char CachedOp::STORAGE_PLAN[] = "storage_plan";
-
-namespace {
-
-std::string AddPrefix(const std::string& prefix,
- const std::string& s) {
- return prefix + "_" + s;
-}
-
-} // namespace
-
-struct CachedOp::GraphInfo {
- nnvm::Graph fwd_graph;
- nnvm::Graph grad_graph;
- nnvm::Graph full_graph;
- std::vector<nnvm::NodeEntry> ograd_entries;
- std::unordered_map<uint32_t, uint32_t> fwd_input_to_grad_output;
- std::vector<OpReqType> bwd_output_reqs;
- std::vector<uint32_t> bwd_input_eid;
-};
-
struct CachedOp::DynamicRuntime {
GraphInfo info;
std::vector<NDArray> buff;
std::vector<OpStatePtr> op_states;
};
-void CreateFullGraph(const nnvm::Symbol& sym,
Review comment:
to allow to be used in both CachedOp and CachedOpThreadSafe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
