anirudh2290 commented on a change in pull request #16654: Multithreaded Inference Support URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r366082854
########## File path: src/imperative/cached_op.cc ########## @@ -32,247 +32,12 @@ DMLC_REGISTER_PARAMETER(CachedOpConfig); constexpr uint32_t kEidNotExist = std::numeric_limits<uint32_t>::max(); -const char CachedOp::FULL[] = "full"; Review comment: added comments to cached_op.cc, moved the constant strings and the helper functions AddPrefix, CreateFullGraph, SetRefCounts, OptimizeRefCounts, CachedOpState to cached_op.h file. Refactored CreateForwardGraph and SetForwardRefCounts into its own function. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
