larroy commented on a change in pull request #16654: Multithreaded Inference
Support
URL: https://github.com/apache/incubator-mxnet/pull/16654#discussion_r366090497
##########
File path: src/imperative/cached_op.h
##########
@@ -26,8 +26,180 @@
#include <utility>
#include <string>
#include <unordered_map>
+#include <map>
+#include "../operator/operator_common.h"
+#include "../operator/subgraph/common.h"
+#include "./imperative_utils.h"
namespace mxnet {
+namespace {
Review comment:
Anon namespace is fine, the question is why is inside mxnet when is dealing
with nnvm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
