ZhennanQin commented on a change in pull request #17265: Add bfloat16
floating-point format support based on AMP
URL: https://github.com/apache/incubator-mxnet/pull/17265#discussion_r366153708
##########
File path: src/engine/naive_engine.cc
##########
@@ -55,7 +55,7 @@ class NaiveEngine final : public Engine {
std::vector<VarHandle> const_vars;
std::vector<VarHandle> mutable_vars;
FnProperty prop;
- const char* opr_name;
+ std::string opr_name;
Review comment:
This is a bugfix for naive engine. If my remember is correct, MXNet already
had this fixed with different approach. So we can drop this change from this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
