kshitij12345 opened a new pull request #17321: Fixes #17304 Flaky Test -> 
test_higher_order_grad.test_tanh
URL: https://github.com/apache/incubator-mxnet/pull/17321
 
 
   @apeforest @reminisce 
   
   Going through the code for `_backward_tanh`, it is implemented as `1 - 
(tanh^2(x))`, which is equivalent to `sech^2(x)` or `(1/cosh(x))^2`. 
   
   However for the failed seed, I have verified that `1 - (tanh^2(x))` is not 
coming equivalent to `(1/ cosh(x))^2` for the randomly generated array of dim 4 
(will try to investigate further for the cause).
   
   For now replacing `grad_op` with its equivalent `1- tanh^2(x)` looks to work 
without the need to relax tolerance.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to