roywei edited a comment on issue #17329: License issue with 1.6.0.rc1
URL: 
https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-574909620
 
 
   > > @hzfan @reminisce @haojin2 Looks like we need to remove the ASF header 
if this file is directly copied from numpy, and add it to whitelist of the 
header check.
   > > 
https://github.com/apache/incubator-mxnet/blob/master/src/operator/numpy/np_einsum_op-inl.h
   > 
   > @roywei The file includes modifications, such as
   > 
   > 
https://github.com/apache/incubator-mxnet/blob/bd67723da96e6d36e72c9a42535a4fe68f234a71/src/operator/numpy/np_einsum_op-inl.h#L1088
   > 
   > It seems valid to re-license the file under Apache license given that the 
original license header is included. (Above link suggests this approach is not 
recommended though)
   > 
   > If we choose not to relicense files with minor modifications, 
https://github.com/apache/incubator-mxnet/blob/master/cmake/Modules/FindCUDAToolkit.cmake
 also needs to be updated to remove the ASF header.
   > The file contains the following minor modifications
   > 
   > 
https://github.com/apache/incubator-mxnet/blob/bd67723da96e6d36e72c9a42535a4fe68f234a71/cmake/Modules/FindCUDAToolkit.cmake#L713-L715
   
   I'll leave the authors to decide whether to add Apache license if it's 
modified by MXNet contributors. Either way, we also need to acknowledge the 
original License and CopyRight in the 
[LICENSE](https://github.com/apache/incubator-mxnet/blob/master/LICENSE) file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to