leezu commented on a change in pull request #17293: [Build] Add a reasonable
default for CMAKE_CUDA_COMPILER in *nix
URL: https://github.com/apache/incubator-mxnet/pull/17293#discussion_r367339823
##########
File path: CMakeLists.txt
##########
@@ -84,6 +84,10 @@ message(STATUS "CMake version '${CMAKE_VERSION}' using
generator '${CMAKE_GENERA
project(mxnet C CXX)
if(USE_CUDA)
cmake_minimum_required(VERSION 3.13.2) # CUDA 10 (Turing) detection
available starting 3.13.2
+ if (NOT MSVC AND (NOT DEFINED CMAKE_CUDA_COMPILER OR
"${CMAKE_CUDA_COMPILER}" STREQUAL "CMAKE_CUDA_COMPILER-NOTFOUND"))
Review comment:
Your current logic may break users from setting CUDACXX environment
variable? That's the standard way of defining Cuda compiler. It's good to
follow standards to avoid technical debt
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
