ChaiBapchya commented on a change in pull request #17372: [BUGFIX] fix model
zoo parallel download
URL: https://github.com/apache/incubator-mxnet/pull/17372#discussion_r368258140
##########
File path: python/mxnet/gluon/utils.py
##########
@@ -240,18 +246,25 @@ def _handle_errors(rv, src):
finally:
raise OSError(msg)
- def _replace_atomic(src, dst):
+ def replace_file(src, dst):
"""Implement atomic os.replace with windows.
+
refer to
https://docs.microsoft.com/en-us/windows/desktop/api/winbase/nf-winbase-movefileexw
The function fails when one of the process(copy, flush, delete) fails.
- Internal use only"""
+
+ Parameters
+ ----------
+ src : source file path
+ dst : destination file path
+ """
_handle_errors(ctypes.windll.kernel32.MoveFileExW(
_str_to_unicode(src), _str_to_unicode(dst),
_windows_default_flags | _MOVEFILE_REPLACE_EXISTING
), src)
-def download(url, path=None, overwrite=False, sha1_hash=None, retries=5,
verify_ssl=True):
+def download(url, path=None, overwrite=False, sha1_hash=None, retries=5,
verify_ssl=True,
+ inplace=False):
"""Download an given URL
Review comment:
nitpick
```suggestion
"""Download a given URL
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
