samskalicky commented on a change in pull request #15969: [WIP] Partitioning
Gluon HybridBlocks
URL: https://github.com/apache/incubator-mxnet/pull/15969#discussion_r369182088
##########
File path: python/mxnet/gluon/block.py
##########
@@ -1040,7 +1043,9 @@ def register_child(self, block, name=None):
super(HybridBlock, self).register_child(block, name)
self._clear_cached_op()
- def hybridize(self, active=True, **kwargs):
+ def hybridize(self, active=True, backend='', optargs={}, **kwargs):
Review comment:
maybe `optargs` should be renamed `backend_args` for consistency? we will
continue to pass kwargs to the C++ CachedOp instance. So want to disambiguate
against options that will be used for partitioning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
