reminisce commented on a change in pull request #17391: fix issue #17389:
Indexing ndarray should give empty array output
URL: https://github.com/apache/incubator-mxnet/pull/17391#discussion_r369183135
##########
File path: python/mxnet/ndarray/ndarray.py
##########
@@ -3096,7 +3096,7 @@ def _get_index_range(start, stop, length, step=1):
start += length
if start < 0:
raise IndexError('Slicing start %d exceeds limit of %d' %
(start-length, length))
- elif start >= length:
Review comment:
This is not sufficient for the fix. It should be also valid when `start >
length`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
