leezu commented on a change in pull request #17297: Fix NCCL Cmake autodetect issue URL: https://github.com/apache/incubator-mxnet/pull/17297#discussion_r369329996
########## File path: cmake/Modules/FindNCCL.cmake ########## @@ -31,7 +31,13 @@ # install NCCL in the same location as the CUDA toolkit. # See https://github.com/caffe2/caffe2/issues/1601 -set(NCCL_ROOT_DIR "" CACHE PATH "Folder contains NVIDIA NCCL") +set(NCCL_ROOT $ENV{NCCL_ROOT} CACHE PATH "Folder contains NVIDIA NCCL") Review comment: @ChaiBapchya Yes, for this PR my concern is only that you are introducing environment variable depencies, which is not standard practice and not needed. So for this PR, let's just remove the 3 lines. For a later PR, NVTX can be refactored. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
