samskalicky commented on a change in pull request #17270: Dynamic custom
operator GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r369383858
##########
File path: include/mxnet/lib_api.h
##########
@@ -328,16 +358,31 @@ typedef void* (*xpu_malloc_t)(void*, int);
*/
class OpResource {
public:
- OpResource(xpu_malloc_t cm, void* ca) : cpu_malloc(cm), cpu_alloc(ca) {}
+ OpResource(xpu_malloc_t cm, void* ca, xpu_malloc_t gm, void* ga, void* st)
Review comment:
I know you're just following the existing precedent, but can we change the
names `cm` to cpu_mem_alloc so its more readable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
