szha commented on issue #17329: License issue with 1.6.0.rc1 URL: https://github.com/apache/incubator-mxnet/issues/17329#issuecomment-577198585 > 2. ./docs/python_docs/themes/mx-theme/mxtheme/static/material-design-icons-3.0.1/iconfont/MaterialIcons-Regular.* > 3. ./3rdparty/mkldnn/doc/assets/mathjax/jax/output/CommonHTML/fonts/TeX/SansSerif-Regular.js > 4. ./3rdparty/mkldnn/doc/assets/mathjax/extensions/TeX/mhchem3/mhchem.js > 5. ./3rdparty/ps-lite/src/ibverbs_van.h > 6. ./src/operator/numpy/np_einsum_path_op-inl.h > 7 ./example/image-classification/predict-cpp/image-classification-predict.cc > 8. ./tests/nightly/sh2ju.sh > 9. ./docs/python_docs/themes/mx-theme/mxtheme/static/font/Roboto/Roboto-Regular.* > 10. ./docs/python_docs/themes/mx-theme/mxtheme/static/webfonts/fa-solid-900.* There are multiple files with multiple headers and an automated tool that checks for multiple headers would have helped. In addition, the checks for these files (except 6) are currently ignored by the following [rat-exclude](https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/apache_rat_license_check/rat-excludes) rules: ``` 3rdparty/* .*svg themes/* image-classification/* ``` It means that these rules should be revisited and we may find more issues hidden by these rules.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
