apeforest commented on a change in pull request #16898: Sparse int64 Large
tensor support
URL: https://github.com/apache/incubator-mxnet/pull/16898#discussion_r369749986
##########
File path: src/c_api/c_api.cc
##########
@@ -972,6 +972,44 @@ int MXNDArrayCreateSparseEx(int storage_type,
Context::Create(static_cast<Context::DeviceType>(dev_type), dev_id),
delay_alloc != 0,
dtype, aux_types, aux_shapes);
+}
+
+int MXNDArrayCreateSparseEx(int storage_type,
+ const uint32_t *shape,
+ uint32_t ndim,
+ int dev_type,
+ int dev_id,
+ int delay_alloc,
+ int dtype,
+ uint32_t num_aux,
+ int *aux_type,
+ uint32_t *aux_ndims,
+ const uint32_t *aux_shape,
+ NDArrayHandle *out) {
+ API_BEGIN();
+ CreateSparseNDArray<uint32_t, uint32_t>(storage_type, shape, ndim, dev_type,
dev_id,
Review comment:
Can we also change the ndim type here from uint32_t to int? It looks strange
to me why 32-bit version uses uint32_t while 64-bit version uses int.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
