connorgoggins commented on a change in pull request #17407: Implemented final two binary ops, added default params for functionality URL: https://github.com/apache/incubator-mxnet/pull/17407#discussion_r369862344
########## File path: benchmark/opperf/utils/op_registry_utils.py ########## @@ -196,6 +196,30 @@ def get_all_broadcast_binary_operators(): return binary_broadcast_mx_operators +def get_all_misc_binary_operators(): + """Gets all miscellaneous binary operators registered with MXNet. + + Returns + ------- + {"operator_name": {"has_backward", "nd_op_handle", "params"}} + """ + # Get all mxnet operators + mx_operators = _get_all_mxnet_operators() + + # Filter for miscellaneous binary operators + binary_misc_mx_operators = {} + for op_name, op_params in mx_operators.items(): + if "choose_element_0index" == op_name and op_params["params"]["narg"] == 5 and \ Review comment: Good point - removing extraneous checks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services