ChaiBapchya commented on a change in pull request #17413: cmake: remove
outdated comments
URL: https://github.com/apache/incubator-mxnet/pull/17413#discussion_r370305799
##########
File path: CMakeLists.txt
##########
@@ -674,13 +677,7 @@ if(USE_PLUGIN_CAFFE)
endif()
endif()
-if(NOT MSVC)
- # Only add c++11 flags and definitions after cuda compiling
- add_definitions(-DDMLC_USE_CXX11)
- add_definitions(-DMSHADOW_IN_CXX11)
- set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS}")
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++0x")
-else()
+if(MSVC)
Review comment:
previously it was added after cuda compiling
1. why was it done before?
2. why is it no longer needed?
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
