ChaiBapchya commented on issue #15768: Fix gradient tensor mutate in 
`{adam/ftrl/rmprop/rmspropalex}_update`.
URL: https://github.com/apache/incubator-mxnet/pull/15768#issuecomment-578579407
 
 
   So I tested *_update ops and it turns out passing randn (which samples from 
uniform distribution) to *_update op (e.g. adam_update) gives output that may 
consist nans
   
   ```
   > 
mx.nd.adam_update(mx.nd.random.randn(10),mx.nd.random.randn(10),mx.nd.random.randn(10),mx.nd.random.randn(10),.01)
   
   [        nan         nan  0.09059371         nan -0.1433481          nan
    -0.5170411   0.381852    0.62985003         nan]
   ```
   Now the way you've tested is checked if input and output has mutation after 
*_update method is called. Does that take into consideration the NaNs?
   
   @kshitij12345

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to