leezu commented on a change in pull request #17448: cmake: staticbuild for binary distribution URL: https://github.com/apache/incubator-mxnet/pull/17448#discussion_r372072523
########## File path: tools/staticbuild/build_lib_cmake.sh ########## @@ -0,0 +1,64 @@ +#!/usr/bin/env bash Review comment: This is alike `build_lib.sh` for the make build. Let's set `set -eo pipefail` in both scripts? With respect to having a bash script: We can migrate to a package manager (conan, vcpk, ...) based solution in the future. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
