samskalicky commented on a change in pull request #17270: Dynamic custom
operator GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17270#discussion_r372603217
##########
File path: Makefile
##########
@@ -664,11 +664,19 @@ cpplint:
pylint:
python3 -m pylint --rcfile=$(ROOTDIR)/ci/other/pylintrc
--ignore-patterns=".*\.so$$,.*\.dll$$,.*\.dylib$$" python/mxnet
-# sample lib for MXNet extension dynamically loading custom operator
-sample_lib:
- $(CXX) -shared -fPIC -std=c++11
example/extensions/lib_custom_op/gemm_lib.cc -o libsample_lib.so -I
include/mxnet
+# MXNet extension dynamically loading libraries
+EXT_LIBS = custom_op_lib subgraph_lib
+ifeq ($(USE_CUDA), 1)
+ EXT_LIBS += custom_op_gpu_lib
+endif
+extension_libs: $(EXT_LIBS)
+
+custom_op_lib:
+ $(CXX) -shared -fPIC -std=c++11
example/extensions/lib_custom_op/gemm_lib.cc -o build/libcustomop_lib.so -I
include/mxnet
+custom_op_gpu_lib:
+ $(NVCC) -shared -std=c++11 -Xcompiler -fPIC
example/extensions/lib_custom_op/relu_lib.cu -o build/libcustomop_gpu_lib.so -I
include/mxnet
Review comment:
we dont need to use the same MXNet flags to build the library, its totally
separate
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
