aaronmarkham commented on a change in pull request #17486: Update CustomOp doc 
with changes for GPU support
URL: https://github.com/apache/incubator-mxnet/pull/17486#discussion_r373215293
 
 

 ##########
 File path: example/extensions/lib_custom_op/README.md
 ##########
 @@ -28,26 +28,39 @@ Custom operators (CustomOp) enable users to write new 
operators without compilin
 
 ### Have MXNet Ready
 
-First you should install MXNet either from compiling from source code or 
download from nightly build. It doesn’t matter if the build comes with CUDA or 
MKLDNN. The custom operator doesn’t interact with the execution of other native 
MXNet operators.
+Custom Operator support was recently merged (#15921, #17270) and is not 
available in a released version of MXNet yet. It will be part of the 
forthcoming 1.7 release, until then please install MXNet by compiling from 
source or downloading one of the nightly builds. For running the example below, 
it doesn’t matter if it is a CUDA, MKLDNN or Vanila build. The custom operator 
doesn’t interact with the execution of other native MXNet operators. Note that 
if you want to run GPU examples and write your custom operators running on GPU, 
you still need MXNet CUDA build.
 
 Review comment:
   ```suggestion
   Custom Operator support was merged (#15921, #17270) and is not available in 
versions of MXNet prior to v1.7.0. To access the feature now, please install 
MXNet by compiling from source using master or using the previously mentioned 
commits, downloading one of the nightly builds, or from a release of MXNet 
1.7.0+. For running the following example, it doesn’t matter if it is a CUDA, 
MKLDNN or plain MXNet build; the custom operator doesn’t interact with the 
execution of other native MXNet operators. Note that if you want to run GPU 
examples and write your custom operators running on GPU, you still need an 
MXNet CUDA build.
   ```
   Adjusted so you don't have to update it later.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to