wkcn commented on a change in pull request #17491: Remove dilation restriction
for conv3d
URL: https://github.com/apache/incubator-mxnet/pull/17491#discussion_r373324316
##########
File path: tests/python/unittest/test_operator.py
##########
@@ -2600,6 +2600,10 @@ def test_convolution_dilated_impulse_response():
for dil in [ (1,1), (2,2), (3,3) ]:
for ks in [ (3,3), (4,4), (2,3), (3,2), (1,1) ]:
test_run_convolution_dilated_impulse_response(dil=dil,
kernel_shape=ks)
+ # 3D
+ for dil in [ (1,1,1), (2,2,2), (3,3,3) ]:
Review comment:
Sorry that I treated dilation as padding by mistake.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
