apeforest commented on a change in pull request #17449: Implemented large
tensor flag for opperf testing
URL: https://github.com/apache/incubator-mxnet/pull/17449#discussion_r373706254
##########
File path: benchmark/opperf/nd_operations/gemm_operators.py
##########
@@ -55,33 +57,62 @@ def run_gemm_operators_benchmarks(ctx=mx.cpu(),
dtype='float32', profiler='nativ
"""
# Benchmark tests for dot and batch_dot operators
- dot_benchmark_res = run_performance_test(
- [getattr(MX_OP_MODULE, "dot")], run_backward=True,
- dtype=dtype, ctx=ctx,
- inputs=[{"lhs": (1024, 1024),
- "rhs": (1024, 1024)},
- {"lhs": (1000, 10),
- "rhs": (1000, 10),
- "transpose_b": True},
- {"lhs": (1000, 1),
- "rhs": (100, 1000),
- "transpose_a": True,
- "transpose_b": True}],
- warmup=warmup, runs=runs, profiler=profiler)
+ if large_tensor == "on":
Review comment:
What happens if this flag is ON and user also specifies custom shapes (which
is small tensor).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services