connorgoggins opened a new pull request #17501: [OpPerf] Implement remaining 
gemm ops
URL: https://github.com/apache/incubator-mxnet/pull/17501
 
 
   ## Description ##
   This PR serves to implement the remaining operators from the gemm category 
in opperf. To achieve this, I added a call to `run_performance_test` for the 
`khatri_rao` op within the `run_gemm_operators_benchmarks` function and, since 
`khatri_rao` has yet to be implemented for GPU, added a check to ensure that 
the context was GPU before running benchmarks for `khatri_rao`. Since 
`khatri_rao` was the only remaining op in the gemm ops category, these were the 
only required changes.
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   - [x] To the best of my knowledge, examples are either not affected by this 
change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - M benchmark/opperf/nd_operations/gemm_operators.py
   
   ## Comments ##
   Tested on p2.16xl w/ubuntu 16.04 and Mac OS with:
   1. Checkout branch and call function `run_gemm_operators_benchmarks` - runs 
all gemm ops (`dot`, `batch_dot`, and `khatri_rao`) on relevant data
   2. Checkout branch and run `opperf.py` (full run of all ops)
   
   ## Performance Results ##
   [Group of operator test - all gemm ops 
(CPU)](https://gist.github.com/connorgoggins/9452ba1c95486208976c8949b493ea14)
   [Full OpPerf test 
(CPU)](https://gist.github.com/connorgoggins/dfc01a53d4732256c6ea28aac9ec7c19)
   
   [Group of operator test - all gemm ops 
(GPU)](https://gist.github.com/connorgoggins/70be016d23c05f36bc2331cf89e4114a)
   [Full OpPerf test 
(GPU)](https://gist.github.com/connorgoggins/51e96e3d62be49c18fe67dfb6c183e65)
   
   @apeforest @access2rohit @ChaiBapchya 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to