connorgoggins opened a new pull request #17511: Implement all miscellaneous ops URL: https://github.com/apache/incubator-mxnet/pull/17511 ## Description ## This PR serves to implement all miscellaneous (not fitting into preexisting categories) operators in OpPerf. To achieve this, I created a file (`benchmark/opperf/nd_operations/misc_operators.py`) with a function (`run_mx_misc_operators_benchmarks`) to run all miscellaneous ops. Within this function, I used calls to `run_performance_test` for the misc ops with positional arguments and a call to a new function I wrote (`get_remaining_miscellaneous_operators`) in conjunction with `run_op_benchmarks` for the misc ops with keyword args. I also added a call to `run_mx_misc_operators_benchmarks` in `opperf.py`. I also added functionality to disable backwards runs on ops that do not support them (`SequenceLast`) and registered a custom op inline to test the `Custom` op. ## Checklist ## ### Essentials ### Please feel free to remove inapplicable items for your PR. - [x] Changes are complete (i.e. I finished coding on this PR) - [x] All changes have test coverage - [x] Code is well-documented - [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change ### Changes ### - A benchmark/opperf/nd_operations/misc_operators.py - M benchmark/opperf/opperf.py - M benchmark/opperf/rules/default_params.py - M benchmark/opperf/utils/benchmark_utils.py - M benchmark/opperf/utils/op_registry_utils.py ## Comments ## Tested on p2.16xl w/ubuntu 16.04 and Mac OS with: 1. Checkout branch and call function `run_mx_misc_operators_benchmarks` - runs all misc ops on relevant data 2. Checkout branch and run `opperf.py` (full run of all ops) ## Performance Results ## [Group of operator test - all misc ops (CPU)](https://gist.github.com/connorgoggins/3fcb9577c8f66765e68eb9de85db54df) [Full OpPerf test (CPU)](https://gist.github.com/connorgoggins/9ca2c04afc77c884fe593c5ffd585c5b) [Group of operator test - all misc ops (GPU)](https://gist.github.com/connorgoggins/5aac7025c60fd136de781284ab37de88) [Full OpPerf test (GPU)](https://gist.github.com/connorgoggins/d39e8d7390816e9453b4a8c2e7a14502) @apeforest @access2rohit @ChaiBapchya
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
