apeforest commented on a change in pull request #17325: Fix Flaky Test Higher
Order Grad
URL: https://github.com/apache/incubator-mxnet/pull/17325#discussion_r374870909
##########
File path: src/nnvm/node_op_util.h
##########
@@ -80,6 +80,12 @@ class NodeOpGen {
dependent_node->attrs.name
+ "_negative",
{x}, nullptr,
&dependent_node)};
}
+
+ nnvm::NodeEntry ones_like(const nnvm::NodeEntry &x) {
Review comment:
Don't we already have an ones_like operator already for use?
https://github.com/apache/incubator-mxnet/blob/971ea4f0adb5bd52cdcdee3e15f390ac05a3d379/src/operator/tensor/init_op.cc#L185
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
